This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vstinner
Recipients giampaolo.rodola, hdima, vstinner
Date 2008-10-13.21:57:42
SpamBayes Score 1.6342069e-08
Marked as misclassified No
Message-id <1223935065.83.0.873566320886.issue3727@psf.upfronthosting.co.za>
In-reply-to
Content
Here is a patch proposition:
 - a socket uses bytes
 - makefile() creates an unicode file using 'r' mode
 - default encoding ISO-8859-1 because I guess that most servers use 
this encoding, but you can change the encoding using "encoding" 
constructor optioan argument
 - read unicode and write unicode: convert convert from/to bytes at 
the last moment (just after/before reading/writing the socket)
 - cosmetic: use .startswith() instead of for example b[:2] == '..'

Test updates:
 - replace "localhost" by HOST
 - write a test for a logging (user + password)

Missing: no SSL unit test. I tested SSL on my personal POP3 account, 
but only the login.
History
Date User Action Args
2008-10-13 21:57:46vstinnersetrecipients: + vstinner, hdima, giampaolo.rodola
2008-10-13 21:57:45vstinnersetmessageid: <1223935065.83.0.873566320886.issue3727@psf.upfronthosting.co.za>
2008-10-13 21:57:45vstinnerlinkissue3727 messages
2008-10-13 21:57:44vstinnercreate