Message74422
The patch looks good to me.
You may want to fix the refleak in the PyList_Append() calls (I counted
4) too:
if (PyList_Append(chunks, chunk)) {
goto bail;
}
should be:
if (PyList_Append(chunks, chunk)) {
Py_DECREF(chunk);
goto bail;
}
Also, line 384 and 548:
Py_DECREF(chunks);
chunks = NULL;
should changed to
Py_CLEAR(chunks); |
|
Date |
User |
Action |
Args |
2008-10-07 03:46:48 | alexandre.vassalotti | set | recipients:
+ alexandre.vassalotti, barry, bob.ippolito, amaury.forgeotdarc, orsenthil, vstinner, christian.heimes, ajaksu2, benjamin.peterson |
2008-10-07 03:46:48 | alexandre.vassalotti | set | messageid: <1223351208.45.0.522219453996.issue3623@psf.upfronthosting.co.za> |
2008-10-07 03:46:47 | alexandre.vassalotti | link | issue3623 messages |
2008-10-07 03:46:47 | alexandre.vassalotti | create | |
|