Author alexandre.vassalotti
Recipients ajaksu2, alexandre.vassalotti, amaury.forgeotdarc, barry, benjamin.peterson, bob.ippolito, christian.heimes, orsenthil, vstinner
Date 2008-10-07.03:46:47
SpamBayes Score 1.79071e-07
Marked as misclassified No
Message-id <1223351208.45.0.522219453996.issue3623@psf.upfronthosting.co.za>
In-reply-to
Content
The patch looks good to me. 

You may want to fix the refleak in the PyList_Append() calls (I counted
4) too:

            if (PyList_Append(chunks, chunk)) {
                goto bail;
            }

should be:

            if (PyList_Append(chunks, chunk)) {
                Py_DECREF(chunk);
                goto bail;
            }

Also, line 384 and 548:

    Py_DECREF(chunks);
    chunks = NULL;

should changed to

    Py_CLEAR(chunks);
History
Date User Action Args
2008-10-07 03:46:48alexandre.vassalottisetrecipients: + alexandre.vassalotti, barry, bob.ippolito, amaury.forgeotdarc, orsenthil, vstinner, christian.heimes, ajaksu2, benjamin.peterson
2008-10-07 03:46:48alexandre.vassalottisetmessageid: <1223351208.45.0.522219453996.issue3623@psf.upfronthosting.co.za>
2008-10-07 03:46:47alexandre.vassalottilinkissue3623 messages
2008-10-07 03:46:47alexandre.vassalotticreate