This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vstinner
Recipients benjamin.peterson, loewis, vstinner
Date 2008-10-03.10:29:24
SpamBayes Score 4.47975e-14
Marked as misclassified No
Message-id <200810031229.33697.victor.stinner@haypocalc.com>
In-reply-to <1223001852.85.0.796626626575.issue4023@psf.upfronthosting.co.za>
Content
Le Friday 03 October 2008 04:44:13 Benjamin Peterson, vous avez écrit :
> You're patch looks pretty good. Could you write tests for it, though?

My patch doesn't work, that's why I don't write unit test :-)
 - os.getcwdu() was correctly replaced
 - getcwdu() was also replaced
 - but not "from os import getcwdu"

Since most people use os.getcwdu(), and that 2to3 is unable to make sure that 
getcwdu() comes from os or is an user defined module, I prefer to only keep 
the first fixer (os.getcwdu() => os.getcwd()). The new patch include a test.

(Let's try Roundup by email using an attachment :-))
Files
File name Uploaded
fix_getcwdu-2.patch vstinner, 2008-10-03.10:29:23
History
Date User Action Args
2008-10-03 10:29:37vstinnersetrecipients: + vstinner, loewis, benjamin.peterson
2008-10-03 10:29:24vstinnerlinkissue4023 messages
2008-10-03 10:29:24vstinnercreate