Message74235
Le Friday 03 October 2008 04:44:13 Benjamin Peterson, vous avez écrit :
> You're patch looks pretty good. Could you write tests for it, though?
My patch doesn't work, that's why I don't write unit test :-)
- os.getcwdu() was correctly replaced
- getcwdu() was also replaced
- but not "from os import getcwdu"
Since most people use os.getcwdu(), and that 2to3 is unable to make sure that
getcwdu() comes from os or is an user defined module, I prefer to only keep
the first fixer (os.getcwdu() => os.getcwd()). The new patch include a test.
(Let's try Roundup by email using an attachment :-)) |
|
Date |
User |
Action |
Args |
2008-10-03 10:29:37 | vstinner | set | recipients:
+ vstinner, loewis, benjamin.peterson |
2008-10-03 10:29:24 | vstinner | link | issue4023 messages |
2008-10-03 10:29:24 | vstinner | create | |
|