Message 74047 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	josiahcarlson
Recipients	barry, giampaolo.rodola, jafo, jcea, josiahcarlson
Date	2008-09-29.20:53:42
SpamBayes Score	4.848035e-07
Marked as misclassified	No
Message-id	<1222721623.46.0.457051600089.issue1745035@psf.upfronthosting.co.za>
In-reply-to

Content
The patch does not work as Giampaolo intends. If the patch were applied as-is, no emails longer than 998 bytes could be sent. Instead, incrementing linelen in the collect_incoming_data() method should only be performed if self.terminator == '\r\n'. I can apply a modified version of this patch against trunk after 2.6 is released. Backports to 2.5 and 2.6 should then be discussed.

The patch does not work as Giampaolo intends.  If the patch were applied 
as-is, no emails longer than 998 bytes could be sent.

Instead, incrementing linelen in the collect_incoming_data() method 
should only be performed if self.terminator == '\r\n'.

I can apply a modified version of this patch against trunk after 2.6 is 
released.  Backports to 2.5 and 2.6 should then be discussed.

History
Date	User	Action	Args
2008-09-29 20:53:43	josiahcarlson	set	recipients: + josiahcarlson, barry, jafo, jcea, giampaolo.rodola
2008-09-29 20:53:43	josiahcarlson	set	messageid: <1222721623.46.0.457051600089.issue1745035@psf.upfronthosting.co.za>
2008-09-29 20:53:42	josiahcarlson	link	issue1745035 messages
2008-09-29 20:53:42	josiahcarlson	create