Author ncoghlan
Recipients barry, benjamin.peterson, brett.cannon, exarkun, ncoghlan, pitrou
Date 2008-09-10.15:19:37
SpamBayes Score 2.17703e-11
Marked as misclassified No
Message-id <1221060046.17.0.727410188982.issue3781@psf.upfronthosting.co.za>
In-reply-to
Content
Cleanup patch now attached. Details of changes:

- warnings.catch_warnings() now has reentry guards (and associated
tests) to prevent silent errors when misused

- added back a test_support.check_warnings() convenience wrapper
(deliberately changing the name to be different from the context manager
in the warnings module). This wrapper is no longer configurable - it is
now used solely for tests that want to record normal warnings and check
the results.

- restored the w.reset() calls that went away in the previous checkin

- unit tests that want to test a different module, or don't want
warnings recorded now consistently use warnings.catch_warnings() directly

- cleanups up to the respective documentation

- cleanups to test_py3kwarn so it is better behaved when other tests are
run before it (the lack of reinitialisation of extension modules still
causes problems though)

- tested with "./python -3 -m test.regrtest -uall -x test_ossaudiodev"
(exclusion is needed because test_ossaudiodev hasn't worked properly on
my machine in a very long time - the audio file playback runs overtime
and I've never found the time to figure out why)

Just needs a review and then should be good to go.
History
Date User Action Args
2008-09-10 15:20:46ncoghlansetrecipients: + ncoghlan, barry, brett.cannon, exarkun, pitrou, benjamin.peterson
2008-09-10 15:20:46ncoghlansetmessageid: <1221060046.17.0.727410188982.issue3781@psf.upfronthosting.co.za>
2008-09-10 15:19:45ncoghlanlinkissue3781 messages
2008-09-10 15:19:43ncoghlancreate