Author gregory.p.smith
Recipients benjamin.peterson, gregory.p.smith, mrabarnett, pitrou
Date 2008-09-09.21:26:07
SpamBayes Score 3.08364e-13
Marked as misclassified No
Message-id <1220995568.79.0.461649830678.issue3825@psf.upfronthosting.co.za>
In-reply-to
Content
This sounds really neat.  but as Anotine said it'll be several weeks 
before any of us can give this serious attention.  Definitely update to 
trunk and base your work off of that.

quick comments:

Your _sre.c diff appears to remove and replace the entire file.  I don't 
think thats actually what you did.  Chances are that diff is a result of 
changed newline f lea.  Can you please make sure your file uses the 
previous line ending style so that the diff is more managable.

Also, please include unit test updates to validate all new functionality 
in Lib/test/test_re.py.

thanks for your efforts!  -gps
History
Date User Action Args
2008-09-09 21:26:08gregory.p.smithsetrecipients: + gregory.p.smith, pitrou, benjamin.peterson, mrabarnett
2008-09-09 21:26:08gregory.p.smithsetmessageid: <1220995568.79.0.461649830678.issue3825@psf.upfronthosting.co.za>
2008-09-09 21:26:08gregory.p.smithlinkissue3825 messages
2008-09-09 21:26:07gregory.p.smithcreate