Author benjamin.peterson
Recipients barry, benjamin.peterson, brett.cannon, exarkun, pitrou
Date 2008-09-08.22:12:40
SpamBayes Score 2.06091e-05
Marked as misclassified No
Message-id <1220911962.24.0.468099971845.issue3781@psf.upfronthosting.co.za>
In-reply-to
Content
The patch mostly looks good. However, all the w[-1] logic looks rather
verbose to me since its main use case in testing will be making sure
*one* warning happened. Returning a list adds the extra step of checking
the length and then indexing it for the warning validation. I'm not
completely suggesting that you bring back the smart list, but maybe an
option on catch_warning to just yield the WarningMessage on __enter__.
History
Date User Action Args
2008-09-08 22:12:42benjamin.petersonsetrecipients: + benjamin.peterson, barry, brett.cannon, exarkun, pitrou
2008-09-08 22:12:42benjamin.petersonsetmessageid: <1220911962.24.0.468099971845.issue3781@psf.upfronthosting.co.za>
2008-09-08 22:12:41benjamin.petersonlinkissue3781 messages
2008-09-08 22:12:41benjamin.petersoncreate