Author mark.dickinson
Recipients facundobatista, gvanrossum, jyasskin, mark.dickinson, ncoghlan, rhettinger
Date 2008-06-30.21:37:35
SpamBayes Score 0.000917444
Marked as misclassified No
Message-id <1214861857.95.0.566473532158.issue1682@psf.upfronthosting.co.za>
In-reply-to
Content
> I agree that if the type of the 2nd arg isn't int or long it should be
> rejected. That should not slow down the common path (two ints).

I'm having second thoughts about this;  it doesn't seem worth adding an 
extra check that has to be applied every time a Fraction is created from a 
string (or another Rational instance).  The condition being checked for (a 
denominator equal to 1, but not of type int or long) is unlikely to occur 
in practice, and fairly harmless even if it does occur.  So I'm thinking 
that PBP says leave it alone.
History
Date User Action Args
2008-06-30 21:37:38mark.dickinsonsetspambayes_score: 0.000917444 -> 0.000917444
recipients: + mark.dickinson, gvanrossum, rhettinger, facundobatista, ncoghlan, jyasskin
2008-06-30 21:37:38mark.dickinsonsetspambayes_score: 0.000917444 -> 0.000917444
messageid: <1214861857.95.0.566473532158.issue1682@psf.upfronthosting.co.za>
2008-06-30 21:37:36mark.dickinsonlinkissue1682 messages
2008-06-30 21:37:36mark.dickinsoncreate