This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author pitrou
Recipients belopolsky, benjamin.peterson, pitrou, rhettinger
Date 2008-06-28.20:31:53
SpamBayes Score 0.00029133566
Marked as misclassified No
Message-id <1214685111.6074.20.camel@fsol>
In-reply-to <1214683920.0.0.448485902593.issue3081@psf.upfronthosting.co.za>
Content
Le samedi 28 juin 2008 à 20:12 +0000, Raymond Hettinger a écrit :
> Raymond Hettinger <rhettinger@users.sourceforge.net> added the comment:
> 
> -1 on the new macros.  The mnemonic doesn't work for me and the example 
> code fragments are to my eyes less readable than before.  These add to 
> the learning curve for reading and writing C extensions and provide 
> nearly zero benefits.  

They might not be ideal, but I think they can be helpful to avoid
writing incorrect code out of laziness. There is already Py_CLEAR with
similar purposes.

> Assigning from an INCREF feels weird.  It is somewhat at odds with our 
> coding style where we tend to stick with dirt simple C, trying to put 
> operations on different lines rather than combining too many step in a 
> single line.

Ok.
History
Date User Action Args
2008-06-28 20:31:54pitrousetspambayes_score: 0.000291336 -> 0.00029133566
recipients: + pitrou, rhettinger, belopolsky, benjamin.peterson
2008-06-28 20:31:53pitroulinkissue3081 messages
2008-06-28 20:31:53pitroucreate