Message 68302 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	loewis
Recipients	amaury.forgeotdarc, belopolsky, benjamin.peterson, bmiller, loewis, rhettinger
Date	2008-06-17.05:22:59
SpamBayes Score	0.024984661
Marked as misclassified	No
Message-id	<1213680182.53.0.244474364392.issue2610@psf.upfronthosting.co.za>
In-reply-to

Content
After reviewing this again, I'm skeptical that this is a good idea. It doesn't achieve its original purpose (anymore), as it only changes tp_str for range objects (although it does change tp_repr for dict views - why this inconsistency?). So I'm -0 on the patch, meaning that I won't commit it, but won't object to anybody else committing it, either. Technically, in dictview_repr, the first call to PyUnicode_Concat isn't checked for exceptions.

After reviewing this again, I'm skeptical that this is a good idea. It
doesn't achieve its original purpose (anymore), as it only changes
tp_str for range objects (although it does change tp_repr for dict views
- why this inconsistency?).

So I'm -0 on the patch, meaning that I won't commit it, but won't object
to anybody else committing it, either.

Technically, in dictview_repr, the first call to PyUnicode_Concat isn't
checked for exceptions.

History
Date	User	Action	Args
2008-06-17 05:23:03	loewis	set	spambayes_score: 0.0249847 -> 0.024984661 recipients: + loewis, rhettinger, amaury.forgeotdarc, belopolsky, benjamin.peterson, bmiller
2008-06-17 05:23:02	loewis	set	spambayes_score: 0.0249847 -> 0.0249847 messageid: <1213680182.53.0.244474364392.issue2610@psf.upfronthosting.co.za>
2008-06-17 05:23:01	loewis	link	issue2610 messages
2008-06-17 05:22:59	loewis	create