Author georg.brandl
Recipients belopolsky, draghuram, georg.brandl, gustavo, tarek
Date 2008-05-23.10:02:56
SpamBayes Score 0.0587621
Marked as misclassified No
Message-id <1211536993.81.0.0506196814327.issue2663@psf.upfronthosting.co.za>
In-reply-to
Content
Hi Tarek,

here's a review:

* The new docs are not very clear about ignore_patterns being a function
factory. E.g.:

"""The callable must return a list of folder and file names relative to
the path, that will be ignored in the copy process.
:func:`ignore_patterns` is an example of such callable."""

Rather, the *return value* of ignore_patterns is an example of such a
callable.

* The new docs should also note that copytree is called recursively, and
therefore the ignore callable will be called once for each directory
that is copied.

* Instead of "path and its elements" the terminology should be
"directory" and "the list of its contents, as returned by os.listdir()".
Likewise, "folder" should be "directory".

* The second new example makes me wonder if *ignore* is the correct name
for the parameter. Is *filter* better?

* A nit; the signature should be "copytree(src, dst[, symlinks[, ignore]])".

* The patch adds a space in the definition of rmtree().
History
Date User Action Args
2008-05-23 10:03:19georg.brandlsetspambayes_score: 0.0587621 -> 0.0587621
recipients: + georg.brandl, belopolsky, gustavo, draghuram, tarek
2008-05-23 10:03:16georg.brandlsetspambayes_score: 0.0587621 -> 0.0587621
messageid: <1211536993.81.0.0506196814327.issue2663@psf.upfronthosting.co.za>
2008-05-23 10:03:08georg.brandllinkissue2663 messages
2008-05-23 10:03:07georg.brandlcreate