This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author belopolsky
Recipients belopolsky, loewis, mark.dickinson
Date 2008-05-10.00:26:57
SpamBayes Score 0.039205298
Marked as misclassified No
Message-id <d38f5330805091726i33fea4fbw2ff0415ec851fdc0@mail.gmail.com>
In-reply-to <1210374501.34.0.776392085612.issue2804@psf.upfronthosting.co.za>
Content
On Fri, May 9, 2008 at 7:08 PM, Martin v. Löwis <report@bugs.python.org> wrote:
..
> I'm -1 on this patch (or any other fixing the perceived problem).
> Special cases aren't special enough to break the rules.
>
> If you ever see this error in a real application, you have deeper
> problems than the exception.

That was my first reaction as well, but then I thought that it was
easy to fix because the answer is guaranteed to be 0 for ridiculously
large right shifts.  However, since the patch is not theoretically
correct, I would only be +0 on applying it.

I also note that the current requirement is that shift fits long
rather than Py_ssize_t, which may lead to a >> sys.maxsize being
invalid on platforms where sizeof(long) < sizeof(Py_ssize_t).  This
may be a problem because sys.maxsize is likely to be used as a
placeholder for an arbitrary large number.

This said, I sill don't feel strongly one way or another.
History
Date User Action Args
2008-05-10 00:27:00belopolskysetspambayes_score: 0.0392053 -> 0.039205298
recipients: + belopolsky, loewis, mark.dickinson
2008-05-10 00:26:59belopolskylinkissue2804 messages
2008-05-10 00:26:57belopolskycreate