Author gvanrossum
Recipients belopolsky, georg.brandl, gvanrossum, rhettinger
Date 2008-04-30.16:48:49
SpamBayes Score 0.125898
Marked as misclassified No
Message-id <1209574131.28.0.208117494257.issue2719@psf.upfronthosting.co.za>
In-reply-to
Content
+1 on this. I have a few nits about the code:

Line 1083: "%.200s object is not an iterator", it->ob_type->tp_name);
Line is too long.

Line 1088: if (res == NULL) {
How about

  if (res != NULL)
    return res;

?

Line 1089: if (def) {
if (def != NULL) {

Line 1093: PyErr_Clear();
I would only call this if PyErr_Occurred() returns true.
History
Date User Action Args
2008-04-30 16:48:51gvanrossumsetspambayes_score: 0.125898 -> 0.125898
recipients: + gvanrossum, georg.brandl, rhettinger, belopolsky
2008-04-30 16:48:51gvanrossumsetspambayes_score: 0.125898 -> 0.125898
messageid: <1209574131.28.0.208117494257.issue2719@psf.upfronthosting.co.za>
2008-04-30 16:48:50gvanrossumlinkissue2719 messages
2008-04-30 16:48:49gvanrossumcreate