This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author jimjjewett
Recipients jimjjewett
Date 2008-04-24.13:52:17
SpamBayes Score 0.018053284
Marked as misclassified No
Message-id <1209045140.34.0.682842030487.issue2679@psf.upfronthosting.co.za>
In-reply-to
Content
feedparser defines four regexs for end-of-line, but two are redundant.

NLCRE checks for the three common line endings.
NLCRE_crack also captures the line ending.
NLCRE_eol also adds a $ to ensure it is at the end.
NLCRE_bol ... is identical to NLCRE_crack.

It should either use a ^ to insist on line-start, or be explicitly the 
same.  (e.g., NLCRE_bol=NLCRE_crack.)  (It gets away with not listing the ^ 
because the current code only uses NLCRE_bol.match.

(Actually, if the regexes are considered private, then the current code 
could just use the bound methods directly ... setting NLCRE_bol to the
 .match method, NLCRE_eol to the .search method, and NLCRE_crack to the
 .split method.)
History
Date User Action Args
2008-04-24 13:52:20jimjjewettsetspambayes_score: 0.0180533 -> 0.018053284
recipients: + jimjjewett
2008-04-24 13:52:20jimjjewettsetspambayes_score: 0.0180533 -> 0.0180533
messageid: <1209045140.34.0.682842030487.issue2679@psf.upfronthosting.co.za>
2008-04-24 13:52:19jimjjewettlinkissue2679 messages
2008-04-24 13:52:18jimjjewettcreate