Author rsc
Recipients benjamin.peterson, rsc
Date 2008-04-24.12:38:26
SpamBayes Score 0.0467707
Marked as misclassified No
Message-id <1209040710.15.0.0584534174667.issue2650@psf.upfronthosting.co.za>
In-reply-to
Content
> The loop in escape should really use enumerate 
> instead of "for i in range(len(pattern))".

It needs i to edit s[i].

> Instead of using a loop, can't the test just
> use "self.assertEqual(re.esacpe(same), same)?" 

Done.

> Also, please add tests for what re.escape should escape.

That's handled in the existing test over all bytes 0-255.
History
Date User Action Args
2008-04-24 12:38:30rscsetspambayes_score: 0.0467707 -> 0.0467707
recipients: + rsc, benjamin.peterson
2008-04-24 12:38:30rscsetspambayes_score: 0.0467707 -> 0.0467707
messageid: <1209040710.15.0.0584534174667.issue2650@psf.upfronthosting.co.za>
2008-04-24 12:38:29rsclinkissue2650 messages
2008-04-24 12:38:28rsccreate