Message 65663 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	belopolsky
Recipients	belopolsky, draghuram, gustavo, tarek
Date	2008-04-21.13:41:53
SpamBayes Score	0.08774096
Marked as misclassified	No
Message-id	<1208785320.48.0.690880398869.issue2663@psf.upfronthosting.co.za>
In-reply-to

Content
On the interface, I would suggest renaming 'exclude' to 'ignore' for consistency with filecmp.dircmp. Also consider detecting file separator in the patterns and interpreting them as an absolute (if pattern.startswith(pathsep)) or relative with respect to src. On the implementation, consider making 'exclude_files' a set for a faster lookup. It should also be possible to refactor the code to avoid checking the type of 'exclude' on every file and every recursion.

On the interface, I would suggest renaming 'exclude' to 'ignore' for 
consistency with filecmp.dircmp. Also consider detecting file separator 
in the patterns and interpreting them as an absolute (if 
pattern.startswith(pathsep)) or relative with respect to src. 

On the implementation, consider making 'exclude_files' a set for a 
faster lookup.   It should also be possible to refactor the code to 
avoid checking the type of 'exclude' on every file and every recursion.

History
Date	User	Action	Args
2008-04-21 13:42:03	belopolsky	set	spambayes_score: 0.087741 -> 0.08774096 recipients: + belopolsky, gustavo, draghuram, tarek
2008-04-21 13:42:00	belopolsky	set	spambayes_score: 0.087741 -> 0.087741 messageid: <1208785320.48.0.690880398869.issue2663@psf.upfronthosting.co.za>
2008-04-21 13:41:59	belopolsky	link	issue2663 messages
2008-04-21 13:41:57	belopolsky	create