This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author benjamin.peterson
Recipients benjamin.peterson, bmiller
Date 2008-04-10.21:05:17
SpamBayes Score 0.0606699
Marked as misclassified No
Message-id <1207861518.47.0.481689763459.issue2610@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks for the patch! You can avoid the compiler warning by casting to
reprfunc like this:

(reprfunc)range_str /* tp_str */

Also, some of the whitespace needs reformating. Please put a space
between the parameters passed a function, and remove the ones in the
conditionals.

You should use PyObject_RichCompareBool.

All the calls to functions like PyLong_FromLong and PyNumber_* can
possibly return NULL on error, so you must check for that. Sometimes
it's useful to have a goto for failures at the end of your function in
which you Py_XDECREF everything.

Could you take the space from the "<" and ">" at the end of the
representation?
History
Date User Action Args
2008-04-10 21:05:18benjamin.petersonsetspambayes_score: 0.0606699 -> 0.0606699
recipients: + benjamin.peterson, bmiller
2008-04-10 21:05:18benjamin.petersonsetspambayes_score: 0.0606699 -> 0.0606699
messageid: <1207861518.47.0.481689763459.issue2610@psf.upfronthosting.co.za>
2008-04-10 21:05:17benjamin.petersonlinkissue2610 messages
2008-04-10 21:05:17benjamin.petersoncreate