➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author belopolsky
Recipients amaury.forgeotdarc, belopolsky, jnferguson
Date 2008-04-09.17:54:16
SpamBayes Score 0.32850865
Marked as misclassified No
Message-id <d38f5330804091054w5a837572i7233073afbcc1732@mail.gmail.com>
In-reply-to <1207761391.61.0.745995657786.issue2588@psf.upfronthosting.co.za>
Content 
On Wed, Apr 9, 2008 at 1:16 PM, Justin Ferguson <report@bugs.python.org> wrote:
..
>  That said, theres plenty of other implementations that manage this
>  without the potential of underflowing a buffer
>

Do you have in mind something like the following?

===================================================================
--- Python/mysnprintf.c (revision 62211)
+++ Python/mysnprintf.c (working copy)
@@ -88,6 +88,7 @@
        PyMem_FREE(buffer);
 Done:
 #endif
-       str[size-1] = '\0';
+       if (size > 0)
+               str[size-1] = '\0';
        return len;
 }

I would be +0 on such change.
History
Date User Action Args
2008-04-09 17:54:18belopolskysetspambayes_score: 0.328509 -> 0.32850865
recipients: + belopolsky, amaury.forgeotdarc, jnferguson
2008-04-09 17:54:17belopolskylinkissue2588 messages
2008-04-09 17:54:16belopolskycreate