Author ajaksu2
Recipients ajaksu2, facundobatista, reacocard
Date 2008-04-09.03:48:43
SpamBayes Score 0.0133085
Marked as misclassified No
Message-id <1207712928.64.0.8059727129.issue2576@psf.upfronthosting.co.za>
In-reply-to
Content
"The code patch is trivial", he said, only to find out it was not :)

Facundo, thanks in advance for taking a look at this!

This patch tries to implement, document and test an optional argument to
HTTPConnection, which passes it to HTTPResponse. So far, it's called
"sockbuf", but I truly hope we can find a better name.

The crux of the test is that it shouldn't be possible to use a buffered
socket and a persistent connection simultaneously, as that was the
reason a buffer was left out (see issue 508157). It also tries to check
correctly allowing Keep-Alive when sockbuf==0. However, it fails to
exercise HTTPResponse properly and needs a review down the
auto-reconnect path. Persistent connections should be tested.

Regarding the code, there's a chance that some changes touching forced
closing are bogus (but not harmful). I'll get back to it and to
persistent connection tests.

Thanks again :)
History
Date User Action Args
2008-04-09 03:48:48ajaksu2setspambayes_score: 0.0133085 -> 0.0133085
recipients: + ajaksu2, facundobatista, reacocard
2008-04-09 03:48:48ajaksu2setspambayes_score: 0.0133085 -> 0.0133085
messageid: <1207712928.64.0.8059727129.issue2576@psf.upfronthosting.co.za>
2008-04-09 03:48:47ajaksu2linkissue2576 messages
2008-04-09 03:48:46ajaksu2create