Message 65191 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	jnferguson
Recipients	jnferguson, rhettinger
Date	2008-04-08.16:49:17
SpamBayes Score	0.18206708
Marked as misclassified	No
Message-id	<1207673358.84.0.480822615953.issue2586@psf.upfronthosting.co.za>
In-reply-to

Content
Just so you know, the scripts actually do two different things-- the bugs are both related to negative values though. One causes PyString_FromStringAndSize() to try an allocate zero bytes (the -24 one), the other causes like 22 bytes to get allocated and then takes advantage of the sign-conversion when the value is assigned to the zlib structure member (the member is unsigned, the value is signed) Honestly, you guys should consider enforcing the safe downcast usage because signedness issues are all over your code base (as I'm sure you know)

Just so you know, the scripts actually do two different things-- the
bugs are both related to negative values though. One causes
PyString_FromStringAndSize() to try an allocate zero bytes (the -24
one), the other causes like 22 bytes to get allocated and then takes
advantage of the sign-conversion when the value is assigned to the zlib
structure member (the member is unsigned, the value is signed)

Honestly, you guys should consider enforcing the safe downcast usage
because signedness issues are all over your code base (as I'm sure you know)

History
Date	User	Action	Args
2008-04-08 16:49:19	jnferguson	set	spambayes_score: 0.182067 -> 0.18206708 recipients: + jnferguson, rhettinger
2008-04-08 16:49:18	jnferguson	set	spambayes_score: 0.182067 -> 0.182067 messageid: <1207673358.84.0.480822615953.issue2586@psf.upfronthosting.co.za>
2008-04-08 16:49:18	jnferguson	link	issue2586 messages
2008-04-08 16:49:17	jnferguson	create