This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author pitrou
Recipients alexandre.vassalotti, brett.cannon, georg.brandl, gvanrossum, pitrou
Date 2008-03-30.20:29:50
SpamBayes Score 0.041378103
Marked as misclassified No
Message-id <1206908992.14.0.262812677401.issue1751@psf.upfronthosting.co.za>
In-reply-to
Content
Ok I took a detailed look at _bytesio.c.

In write_bytes() there is the following resizing logic:

    if (self->pos + len > self->string_size) {
        if (resize_buffer(self, self->pos + len) < 0)
            return -1;
    }

Replacing `self->string_size` with `self->buf_size` should avoid some
spurious reallocations.

For some reason, using the help() function on a BytesIO instance does
not display the class help.

Overall, the new module looks fine. I can't say anything about the io.py
or _fileio.c fixes.
History
Date User Action Args
2008-03-30 20:29:52pitrousetspambayes_score: 0.0413781 -> 0.041378103
recipients: + pitrou, gvanrossum, brett.cannon, georg.brandl, alexandre.vassalotti
2008-03-30 20:29:52pitrousetspambayes_score: 0.0413781 -> 0.0413781
messageid: <1206908992.14.0.262812677401.issue1751@psf.upfronthosting.co.za>
2008-03-30 20:29:51pitroulinkissue1751 messages
2008-03-30 20:29:51pitroucreate