Author pje
Recipients paul.moore, pje
Date 2008-03-20.23:28:50
SpamBayes Score 0.0
Marked as misclassified No
Message-id <1206055732.01.0.864252639363.issue2439@psf.upfronthosting.co.za>
In-reply-to
Content
Oops, my bad.  I'm thinking of an entirely unrelated get_loader()
function.  Meanwhile, I misread your patch entirely, and thought you had
some dead code for os.path processing that is in fact live.  So there is
"another" problem (really the only one) that I spotted on this re-read.

Your patch is calling load_module() even if the module is already in
sys.modules.  This will *reload* the module, potentially causing
problems elsewhere in the system.  You can test this by adding an
assertion to your test's load_module(), that the module isn't already in
sys.modules.  Then call get_data for the same module twice.

Sorry again for the mixup.
History
Date User Action Args
2008-07-26 13:54:04georg.brandlsetspambayes_score: 0.774055 -> 0.0
2008-03-20 23:28:52pjesetspambayes_score: 0.774055 -> 0.774055
recipients: + pje, paul.moore
2008-03-20 23:28:52pjesetspambayes_score: 0.774055 -> 0.774055
messageid: <1206055732.01.0.864252639363.issue2439@psf.upfronthosting.co.za>
2008-03-20 23:28:51pjelinkissue2439 messages
2008-03-20 23:28:50pjecreate