This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author MrJean1
Recipients MrJean1, fdrake
Date 2008-03-08.21:05:28
SpamBayes Score 0.00254753
Marked as misclassified No
Message-id <1205010332.17.0.439675218391.issue2218@psf.upfronthosting.co.za>
In-reply-to
Content
There are 7 other, potentially serious issues in the original _hotshot.c 
file.  All those are being fixed for the next version of the enhanced 
hotshot files.

The 7 issues are:

1) functions flush_data and do_stop may create an infinite recursion on 
line 567.

2) The pack_string and pack_add_info functions do not check for string 
lengths exceeding BUFFERSIZE and may corrupt memory in that case.

3) In line 1182, linetimings should be frametimngs:
   {"frametimings", T_LONG, offsetof(ProfilerObject, linetimings), 
READONLY},

4) Coverage members frametimings, linetimings and lineevents are set on 
line 1562 ff. after different values may have been written into the log 
file header by function write_header on lines 1440 ff.

5) The coverage__doc__ on line 1546 is incomplete.

6) At several places, errors are detected but not reported and not sets.

7) An int value is passed where a long is specified or expected.  T_LONG 
should be T_INT on lines 1182-1184 and there are several calls to PyInt_FromLong with an int argument on line 487 ff. and other places.
History
Date User Action Args
2008-03-08 21:05:32MrJean1setspambayes_score: 0.00254753 -> 0.00254753
recipients: + MrJean1, fdrake
2008-03-08 21:05:32MrJean1setspambayes_score: 0.00254753 -> 0.00254753
messageid: <1205010332.17.0.439675218391.issue2218@psf.upfronthosting.co.za>
2008-03-08 21:05:30MrJean1linkissue2218 messages
2008-03-08 21:05:28MrJean1create