This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author belopolsky
Recipients belopolsky, georg.brandl, ocean-city
Date 2008-03-07.15:55:55
SpamBayes Score 0.00231369
Marked as misclassified No
Message-id <1204905362.96.0.267342659823.issue2222@psf.upfronthosting.co.za>
In-reply-to
Content
Aha!  I did not know about the cleanup.  Maybe that should be documented 
as well.

This shows that using O& with a converter returning a PyObject* is a bad 
idea.  (General clean-up is not possible for O& because there is no way 
to tell what type the converter returns.)

I am still +1 on your original patch.  It is obviously correct and fixes 
the bug with minimum of changes.  However, win32 code in posixmodule.c 
needs some clean-up.  convert_to_unicode should be eliminated in favor 
of the approach used in win32_1str.  It may also make sense to move 
conversion/api selection code to a win32_2str function.  Even if it will 
be only used for rename, it will make the code more readable by making 
win32 code structure similar to posix.

All this is a topic for another issue.  I believe the only thing that 
needs to be done here is to enable error case testing for all platforms 
in the unit test.
History
Date User Action Args
2008-03-07 15:56:03belopolskysetspambayes_score: 0.00231369 -> 0.00231369
recipients: + belopolsky, georg.brandl, ocean-city
2008-03-07 15:56:02belopolskysetspambayes_score: 0.00231369 -> 0.00231369
messageid: <1204905362.96.0.267342659823.issue2222@psf.upfronthosting.co.za>
2008-03-07 15:55:56belopolskylinkissue2222 messages
2008-03-07 15:55:55belopolskycreate