Author jyasskin
Recipients akuchling, jyasskin, phr, pilcrow, skip.montanaro, werneck, zanella
Date 2008-03-02.08:18:34
SpamBayes Score 0.00984017
Marked as misclassified No
Message-id <1204445919.95.0.824880430952.issue1193577@psf.upfronthosting.co.za>
In-reply-to
Content
It seems that .await_request() was only added a month ago to fix issue
742598, so it's no great hardship to refactor it again now. Timeouts
never worked for .serve_forever() because the try/except in
.handle_request() turned their exception into a plain return, which
didn't stop .server_forever() from looping. Timeouts also seem to be
unnecessary in a situation in which shutdown works. Shutdown can only be
called from a separate thread, and when you have more threads you can
also do periodic tasks in them.

So I've made that explicit: the .serve_forever/shutdown combination
doesn't handle timeouts. [This has nothing to do with the fact that it
takes three times as much code to handle them. Don't look at the excuse
behind the curtain. ;)]

This patch needs some more documentation and a NEWS entry before it gets
submitted, but I want to check that everyone would be happy with the
concept.
History
Date User Action Args
2008-03-02 08:18:40jyasskinsetspambayes_score: 0.00984017 -> 0.00984017
recipients: + jyasskin, skip.montanaro, akuchling, phr, pilcrow, zanella, werneck
2008-03-02 08:18:39jyasskinsetspambayes_score: 0.00984017 -> 0.00984017
messageid: <1204445919.95.0.824880430952.issue1193577@psf.upfronthosting.co.za>
2008-03-02 08:18:39jyasskinlinkissue1193577 messages
2008-03-02 08:18:38jyasskincreate