Message 62325 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	loewis
Recipients	amaury.forgeotdarc, belopolsky, gregory.p.smith, gvanrossum, loewis
Date	2008-02-12.18:40:39
SpamBayes Score	0.038721226
Marked as misclassified	No
Message-id	<1202841641.68.0.864067510301.issue2016@psf.upfronthosting.co.za>
In-reply-to

Content
I think we agree that this patch has the potential of breaking existing valid code. So based on the policy that we should avoid doing so in a bugfix release, I'd rather reject that fix (fix2016.txt) for 2.5.x. OTOH, if it is really unlikely that is ever occurs in existing code, there would be no point in backporting it to 2.5.x, since the check wouldn't trigger. I also can't see a security concern - applications shouldn't pass untrusted objects as keyword arguments (if they were, such objects could put their malicious code inside __hash__).

I think we agree that this patch has the potential of breaking existing
valid code. So based on the policy that we should avoid doing so in a
bugfix release, I'd rather reject that fix (fix2016.txt) for 2.5.x.
OTOH, if it is really unlikely that is ever occurs in existing code,
there would be no point in backporting it to 2.5.x, since the check
wouldn't trigger. 

I also can't see a security concern - applications shouldn't pass
untrusted objects as keyword arguments (if they were, such objects could
 put their malicious code inside __hash__).

History
Date	User	Action	Args
2008-02-12 18:40:41	loewis	set	spambayes_score: 0.0387212 -> 0.038721226 recipients: + loewis, gvanrossum, gregory.p.smith, amaury.forgeotdarc, belopolsky
2008-02-12 18:40:41	loewis	set	spambayes_score: 0.0387212 -> 0.0387212 messageid: <1202841641.68.0.864067510301.issue2016@psf.upfronthosting.co.za>
2008-02-12 18:40:40	loewis	link	issue2016 messages
2008-02-12 18:40:39	loewis	create