This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author donmez
Recipients alexandre.vassalotti, christian.heimes, donmez, gregory.p.smith, gvanrossum, loewis, nnorwitz
Date 2008-01-28.03:02:22
SpamBayes Score 0.0024604835
Marked as misclassified No
Message-id <>

I'll try to answer your questions one by one, first with _csv.c compiler
issues :

Modules/_csv.c:969: warning: assuming signed overflow does not occur
when simplifying conditional to constant

There is a check inside loop like this:

               if (c == '\0')

Instead of this if we do the check in the for :

+       for (i = 0; i < strlen(field) ; i++) {

and remove the if check compiler no longer issues a warning also csv
test passes with this. Attached patch implements this optimization.

Guido, you don't have to shout, you know noone pays me per python
bugreport I create :)
Date User Action Args
2008-01-28 03:02:24donmezsetspambayes_score: 0.00246048 -> 0.0024604835
recipients: + donmez, gvanrossum, loewis, nnorwitz, gregory.p.smith, christian.heimes, alexandre.vassalotti
2008-01-28 03:02:23donmezsetspambayes_score: 0.00246048 -> 0.00246048
messageid: <>
2008-01-28 03:02:23donmezlinkissue1621 messages
2008-01-28 03:02:22donmezcreate