Author gvanrossum
Recipients alexandre.vassalotti, christian.heimes, donmez, gregory.p.smith, gvanrossum, loewis, nnorwitz
Date 2008-01-28.02:41:25
SpamBayes Score 0.158284
Marked as misclassified No
Message-id <1201488086.26.0.566497123574.issue1621@psf.upfronthosting.co.za>
In-reply-to
Content
Unfortunately I have no time to work on this myself, but in order to
make progress I recommend checking in things piecemeal so that the same
changes don't get reviewed over and over again.  I propose that each
submit reference this bug ("Partial fix for issue #1621" I'd suggest)
and that the submits are recorded here (e.g. "fixed <filename> in rXXX
(2.5.2), rYYY (2.6)").  Then hopefully only a few hard cases will remain.

With Neal, I don't see what the warning in _csv is about. What condition
is being turned into a constant? Is the compiler perhaps rearranging the
code so as to insert "if (field[0] == '\0') goto XXX;" in front of the
for-loop where XXX jumps into the middle of the condition in the
if-statement immediately following the for-loop, and skipping that
if-block when breaking of the loop later? That would be clever, and
correct, and I'm not sure if making i unsigned is going to help -- in
fact it might make the compiler decide it can't use that optimization...
History
Date User Action Args
2008-01-28 02:41:26gvanrossumsetspambayes_score: 0.158284 -> 0.158284
recipients: + gvanrossum, loewis, nnorwitz, gregory.p.smith, christian.heimes, alexandre.vassalotti, donmez
2008-01-28 02:41:26gvanrossumsetspambayes_score: 0.158284 -> 0.158284
messageid: <1201488086.26.0.566497123574.issue1621@psf.upfronthosting.co.za>
2008-01-28 02:41:25gvanrossumlinkissue1621 messages
2008-01-28 02:41:25gvanrossumcreate