Author mark.dickinson
Recipients alanmcintyre, inducer, loewis, mark.dickinson
Date 2008-01-08.20:55:47
SpamBayes Score 0.00351036
Marked as misclassified No
Message-id <1199825750.11.0.307107622036.issue1381@psf.upfronthosting.co.za>
In-reply-to
Content
A note to any potential reviewers for this patch (cmath3.patch):  I'm especially 
looking for non-mathematical feedback here, so please don't be put off by the 
mathematics.  Some questions:

- there's a new file cmath.ctest containing testcases;  should this be put 
directly into Lib/test (where it is right now), or is there a better place.  Is 
the name of this file reasonable?

- is the new stuff in pyport.h (checks for _copysign and copysign, and automatic 
renaming of _copysign to copysign) okay?  Should it be in cmathmodule.c instead?

- is the code in test_cmath that looks for the testcase file okay?

And it would be really great if someone with access to a Windows box could just 
verify that the tests pass with this patch applied;  I've only tested it on OS X 
and Linux.
History
Date User Action Args
2008-01-08 20:55:50mark.dickinsonsetspambayes_score: 0.00351036 -> 0.00351036
recipients: + mark.dickinson, loewis, alanmcintyre, inducer
2008-01-08 20:55:50mark.dickinsonsetspambayes_score: 0.00351036 -> 0.00351036
messageid: <1199825750.11.0.307107622036.issue1381@psf.upfronthosting.co.za>
2008-01-08 20:55:48mark.dickinsonlinkissue1381 messages
2008-01-08 20:55:47mark.dickinsoncreate