Author gvanrossum
Recipients Rhamphoryncus, christian.heimes, gvanrossum
Date 2007-12-18.19:48:33
SpamBayes Score 0.346285
Marked as misclassified No
Message-id <1198007313.65.0.550878967559.issue1635@psf.upfronthosting.co.za>
In-reply-to
Content
Mostly looks good.  Here are some nits.

(1) You shouldn't have to add pystrcmp.c to the VC project files since
on Windows it isn't used, right?

(2) Will the Windows input routine still accept the *old*
representations for INF and NAN?  IMO that's important (a) so as to be
able to read old pickles or marshalled data, (b) so as to be able to
read data files written by C programs.

(3) Shouldn't you be using Py_HUGE_VAL instead of HUGE_VAL in the chunk
starting at line 187 in floatobject.c?
History
Date User Action Args
2007-12-18 19:48:33gvanrossumsetspambayes_score: 0.346285 -> 0.346285
recipients: + gvanrossum, Rhamphoryncus, christian.heimes
2007-12-18 19:48:33gvanrossumsetspambayes_score: 0.346285 -> 0.346285
messageid: <1198007313.65.0.550878967559.issue1635@psf.upfronthosting.co.za>
2007-12-18 19:48:33gvanrossumlinkissue1635 messages
2007-12-18 19:48:33gvanrossumcreate