This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author gustavo
Recipients ext-, gustavo
Date 2007-12-17.22:28:55
SpamBayes Score 0.03345497
Marked as misclassified No
Message-id <1197930536.53.0.697106332711.issue1772673@psf.upfronthosting.co.za>
In-reply-to
Content
I was about to submit the very same patch :-)
I missed PyErr_NewException, but you missed the PyMapping_* methods ;)

Please look into this matter.  GCC 4.2 has arrived and it has a new
warning.  The code:

     char* kwlist[] = { "target", "encoding", NULL };

now gives a warning like:

"warning: deprecated conversion from string constant to ‘char*’"

at least when compiling in C++ mode...

This means that people have to declare it as "const char* kwlist", which
will then trigger another warning when calling
PyArg_ParseTupleAndKeywords with such a variable, because the prototype is:

PyAPI_FUNC(int) PyArg_ParseTupleAndKeywords(PyObject *, PyObject *,
                                                  const char *, char **,
...);

The "char **" should be "const char **".  ext-, any chance you could fix
that too?
History
Date User Action Args
2007-12-17 22:28:56gustavosetspambayes_score: 0.033455 -> 0.03345497
recipients: + gustavo, ext-
2007-12-17 22:28:56gustavosetspambayes_score: 0.033455 -> 0.033455
messageid: <1197930536.53.0.697106332711.issue1772673@psf.upfronthosting.co.za>
2007-12-17 22:28:56gustavolinkissue1772673 messages
2007-12-17 22:28:55gustavocreate