Author christian.heimes
Recipients christian.heimes, gvanrossum, mark
Date 2007-12-17.12:41:26
SpamBayes Score 0.000205795
Marked as misclassified No
Message-id <1197895287.99.0.36424404917.issue1600@psf.upfronthosting.co.za>
In-reply-to
Content
Hi Mark!

In general the patch is fine but it has some small issues.

* Your patches are all reversed. They remove (-) the new lines instead
of adding (+) them. Why aren't you using svn diff > file.patch?
* You are mixing tabs with spaces. All 2.6 C files and most 3.0 C files
are still using tabs.
* You forgot about %f. For large values the format characters f and F
are using the exponent display, too "%f" % 1e60 == '1e+60'
* You cannot assume that char is unsigned. Use Py_CHARMAP(char) instead.
I think that you can make the code more readable when you do format_char
= tolower(Py_CHARMAP(format_char)); first.
* The code is not C89 conform. The standards dictate that you cannot
declare a var in the middle of a block. New var must be declared right
after the {
History
Date User Action Args
2007-12-17 12:41:28christian.heimessetspambayes_score: 0.000205795 -> 0.000205795
recipients: + christian.heimes, gvanrossum, mark
2007-12-17 12:41:28christian.heimessetspambayes_score: 0.000205795 -> 0.000205795
messageid: <1197895287.99.0.36424404917.issue1600@psf.upfronthosting.co.za>
2007-12-17 12:41:27christian.heimeslinkissue1600 messages
2007-12-17 12:41:26christian.heimescreate