Message 57946 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	theller
Recipients	gregcouch, mthibaut, theller
Date	2007-11-29.18:48:18
SpamBayes Score	0.014208842
Marked as misclassified	No
Message-id	<474F096A.5060306@ctypes.org>
In-reply-to	<1196293321.21.0.637598341341.issue1506@psf.upfronthosting.co.za>

Content
> Greg Couch added the comment: > > Turns out callproc.c forgot to include <ffi_common.h> after <ffi.h> > which conditionally includes alloca.h. So it's a one-line fix. > This would not work. <ffi_common.h> is a file private to libffi; when Python is configured to use the system ffi-library (--with-systemffi) this file is not available. I would tend to replace the three alloca() calls in the function _CallProc() in callbacks.c with calls to malloc(). All the other occurrences of alloca() are only compiled on windows.

> Greg Couch added the comment:
> 
> Turns out callproc.c forgot to include <ffi_common.h> after <ffi.h>
> which conditionally includes alloca.h.  So it's a one-line fix.
> 

This would not work.  <ffi_common.h> is a file private to libffi;
when Python is configured to use the system ffi-library (--with-systemffi)
this file is not available.

I would tend to replace the three alloca() calls in the function
_CallProc() in callbacks.c with calls to malloc().  All the other
occurrences of alloca() are only compiled on windows.

History
Date	User	Action	Args
2007-11-29 18:48:18	theller	set	spambayes_score: 0.0142088 -> 0.014208842 recipients: + theller, gregcouch, mthibaut
2007-11-29 18:48:18	theller	link	issue1506 messages
2007-11-29 18:48:18	theller	create