This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author amaury.forgeotdarc
Recipients alanmcintyre, alexeychen, amaury.forgeotdarc, brett.cannon, christian.heimes, complex, gvanrossum, jafo, nas, nnorwitz, pythonmeister
Date 2007-11-14.10:27:21
SpamBayes Score 0.0101514
Marked as misclassified No
Message-id <1195036042.64.0.306290460172.issue1134@psf.upfronthosting.co.za>
In-reply-to
Content
fp_readl is indeed broken in several ways:
- decoding_buffer should be reset to NULL when all data has been read
(buflen <= size).
- the (buflen > size) case will cause an error on the next pass, since
the function cannot handle PyBytesObject.

IOW, the function is always wrong ;-)

I have a correction ready (jafo's patch already addresses the first
case), but cannot access svn here. I will try to provide a patch + test
cases later tonight.
History
Date User Action Args
2007-11-14 10:27:22amaury.forgeotdarcsetspambayes_score: 0.0101514 -> 0.0101514
recipients: + amaury.forgeotdarc, gvanrossum, nnorwitz, brett.cannon, complex, jafo, alanmcintyre, christian.heimes, pythonmeister, alexeychen, nas
2007-11-14 10:27:22amaury.forgeotdarcsetspambayes_score: 0.0101514 -> 0.0101514
messageid: <1195036042.64.0.306290460172.issue1134@psf.upfronthosting.co.za>
2007-11-14 10:27:22amaury.forgeotdarclinkissue1134 messages
2007-11-14 10:27:21amaury.forgeotdarccreate