This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author draghuram
Recipients alexandre.vassalotti, amaury.forgeotdarc, christian.heimes, draghuram, gvanrossum
Date 2007-11-09.15:50:31
SpamBayes Score 0.022322478
Marked as misclassified No
Message-id <2c51ecee0711090750i1f29d000w3134172e7c685e60@mail.gmail.com>
In-reply-to <ca471dc20711081642p78061bd2na380c597a5a347c1@mail.gmail.com>
Content
On 11/8/07, Guido van Rossum <report@bugs.python.org> wrote:
> I do think there is something iffy here -- the 2.x version of this
> test opens the files in binary mode. I wonder what end users are
> supposed to do.

I think that requirement (need to open in binary mode) is no more
present in 3.0. As per revision 56777 (#1767398), csv module seems to
support unicode strings and as such I would expect that files *should
not* be opened in binary mode (This requires doc change both in csv
doc and "what's new in 3.0). The tests in test_csv are explicitly
writing "\r\n" which seems to be a hangover from 2.x. We seem to have
side-stepped the problem by passing "newline=''" at some places but
the real fix may be changing "\r\n"s to "\n" now that the temp files
are being opened in text mode.
History
Date User Action Args
2007-11-09 15:50:32draghuramsetspambayes_score: 0.0223225 -> 0.022322478
recipients: + draghuram, gvanrossum, amaury.forgeotdarc, christian.heimes, alexandre.vassalotti
2007-11-09 15:50:32draghuramlinkissue1395 messages
2007-11-09 15:50:31draghuramcreate