➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author draghuram
Recipients alexandre.vassalotti, amaury.forgeotdarc, christian.heimes, draghuram, gvanrossum
Date 2007-11-08.18:54:24
SpamBayes Score 0.0045105955
Marked as misclassified No
Message-id <1194548065.14.0.942752491397.issue1395@psf.upfronthosting.co.za>
In-reply-to
Content 
Considering that test_csv is failing on windows even without any changes
related to this issue, I looked at it and came up with this patch:

-----------------
Index: Lib/test/test_csv.py
===================================================================
--- Lib/test/test_csv.py        (revision 58914)
+++ Lib/test/test_csv.py        (working copy)
@@ -375,7 +375,7 @@
 
 class TestCsvBase(unittest.TestCase):
     def readerAssertEqual(self, input, expected_result):
-        with TemporaryFile("w+") as fileobj:
+        with TemporaryFile("w+", newline='') as fileobj:
             fileobj.write(input)
             fileobj.seek(0)
             reader = csv.reader(fileobj, dialect = self.dialect)
-----------------

Does this look ok? The tests pass on windows and Linux.
History
Date User Action Args
2007-11-08 18:54:25draghuramsetspambayes_score: 0.0045106 -> 0.0045105955
recipients: + draghuram, gvanrossum, amaury.forgeotdarc, christian.heimes, alexandre.vassalotti
2007-11-08 18:54:25draghuramsetspambayes_score: 0.0045106 -> 0.0045106
messageid: <1194548065.14.0.942752491397.issue1395@psf.upfronthosting.co.za>
2007-11-08 18:54:25draghuramlinkissue1395 messages
2007-11-08 18:54:24draghuramcreate