Message56698
The following observations were made of the PCBuild8 solution:
1 pyproject.vsprops was missing usermacros for tcltk / msi
2 no vcproj for ssl module like the PCBuild solution has
3 _msi project did not havea valid includedir
4 _tkinter did not have a valid includedir
Suggested Changes:
1 I would like to suggest adding macros such as the following to the
pyproject.vsprops. These could then be referenced throughout the
associated projects.
<UserMacro
Name="tcltkDir"
Value="..\..\..\tcltk"
/>
<UserMacro
Name="msinstDir"
Value="C:\MsiIntel.SDK\"
/>
Reasoning: To continue to promote pyproject.vsprops as being an
almost-one-stop-shop for setting relative locations of third party
libraries. This can be done in the following way:
- tcltkDir could be used to add a valid includedir to the _tkinter project
- msinstDir could be used to add a valid includedir to the _msi project.
2 no vcproj for ssl module like the PCBuild solution has
See: pcbuild8_for_ssl.patch... The only thing left to do is add the
associated _ssl project to the vsproj.
Reasoning: To let their be a way to build the ssl module.
Note: I suppose there could have been good reason for not putting in the
_ssl module, since it uses a support .bat / .py to build (but that's for
better people to decide)
3 If 1 is satisfied, a standard includedir variable could be added
4 If 1 is satisfied, a standard includedir variable could be added
I am hesitant to submit a full patch for all of these here, since it may
be decided that some of these be treated as separate issues. If a full
patch is desired I can submit one. |
|
Date |
User |
Action |
Args |
2007-10-24 03:12:35 | JosephArmbruster | set | spambayes_score: 0.0337808 -> 0.033780847 recipients:
+ JosephArmbruster |
2007-10-24 03:12:35 | JosephArmbruster | set | spambayes_score: 0.0337808 -> 0.0337808 messageid: <1193195555.05.0.403245196794.issue1320@psf.upfronthosting.co.za> |
2007-10-24 03:12:34 | JosephArmbruster | link | issue1320 messages |
2007-10-24 03:12:33 | JosephArmbruster | create | |
|