This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author orsenthil
Recipients dcantrell-rh, jjlee, orsenthil, skip.montanaro
Date 2007-09-25.03:37:42
SpamBayes Score 0.072455995
Marked as misclassified No
Message-id <1190691463.92.0.278275951475.issue1675455@psf.upfronthosting.co.za>
In-reply-to
Content
Hi,
The patch attached required a complete rewrite. I am attaching the
modified patch, which will just substitute socket.gethostbyname with a
function gethost_addrinfo which internally uses getaddrinfo and takes
care of the IPv4 or IPv6 addresses translation.

jjlee, skip: let me know your comments on this.

One note we have to keep in mind is, testing on IPv6 address.
For eg. on my system /etc/hosts
10.98.1.6       goofy.goofy.com
#fe80::219:5bff:fefd:6270       localhost
127.0.0.1       localhost

test_urllib2 will PASS for the above.
But if I uncomment the IPv6 address, opening the local file fails. I am
not sure how local file access is done with IPv6 and should urllib2
(local file opening function) itself needs to be modified. Shall check
into that, with next version.
Files
File name Uploaded
urllib2-getaddrinfo.patch orsenthil, 2007-09-25.03:37:42
History
Date User Action Args
2007-09-25 03:37:44orsenthilsetspambayes_score: 0.072456 -> 0.072455995
recipients: + orsenthil, skip.montanaro, jjlee, dcantrell-rh
2007-09-25 03:37:43orsenthilsetspambayes_score: 0.072456 -> 0.072456
messageid: <1190691463.92.0.278275951475.issue1675455@psf.upfronthosting.co.za>
2007-09-25 03:37:43orsenthillinkissue1675455 messages
2007-09-25 03:37:42orsenthilcreate