Author gvanrossum
Recipients arigo, brett.cannon, gvanrossum
Date 2007-09-16.02:18:59
SpamBayes Score 0.149022
Marked as misclassified No
Message-id <1189909141.08.0.147655949454.issue1164@psf.upfronthosting.co.za>
In-reply-to
Content
Looks Good, except I think it's a bad idea to release/acquire the GIL
for each character when writing the repr() of a string.  Given that the
string is immutable and its refcount kept alive by the caller I don't
see a reason why you can't just reference the object without holding the
GIL.  (Also you might want to copy the size into a local variable, it
won't change...)
History
Date User Action Args
2007-09-16 02:19:01gvanrossumsetspambayes_score: 0.149022 -> 0.149022
recipients: + gvanrossum, brett.cannon, arigo
2007-09-16 02:19:01gvanrossumsetspambayes_score: 0.149022 -> 0.149022
messageid: <1189909141.08.0.147655949454.issue1164@psf.upfronthosting.co.za>
2007-09-16 02:19:01gvanrossumlinkissue1164 messages
2007-09-16 02:19:00gvanrossumcreate