Message 55860 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	gvanrossum
Recipients	gvanrossum, thomaslee
Date	2007-09-12.19:13:29
SpamBayes Score	0.026704282
Marked as misclassified	No
Message-id	<1189624410.18.0.0768551141172.issue1145@psf.upfronthosting.co.za>
In-reply-to

Content
I like this, but the patch has problems: you don't error-check the return value from PyObject_Unicode() or PyUnicode_FromObject() (and why do you need the latter call anyway?) Also in the docstring I would reference str() instead of __str__(). There are also a few lines longer than 80 chars.

I like this, but the patch has problems: you don't error-check the
return value from PyObject_Unicode() or PyUnicode_FromObject() (and why
do you need the latter call anyway?)

Also in the docstring I would reference str() instead of __str__().

There are also a few lines longer than 80 chars.

History
Date	User	Action	Args
2007-09-12 19:13:30	gvanrossum	set	spambayes_score: 0.0267043 -> 0.026704282 recipients: + gvanrossum, thomaslee
2007-09-12 19:13:30	gvanrossum	set	spambayes_score: 0.0267043 -> 0.0267043 messageid: <1189624410.18.0.0768551141172.issue1145@psf.upfronthosting.co.za>
2007-09-12 19:13:30	gvanrossum	link	issue1145 messages
2007-09-12 19:13:29	gvanrossum	create