Message 55855 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	gvanrossum
Recipients	alexandre.vassalotti, andy-chu, gvanrossum, loewis, ncoghlan, paul.moore, pje
Date	2007-09-12.18:39:18
SpamBayes Score	0.0010511032
Marked as misclassified	No
Message-id	<1189622358.8.0.998135009606.issue1739468@psf.upfronthosting.co.za>
In-reply-to

Content
PJE's patch looks good to me too. Stylistic nits: - The proper name of the now-public null importer type ought to be PyNullImporter_Type, to rhyme with e.g. PyString_Type - There's a multi-line if that has the closing parenthesis in an odd place at the start of the next line. The preferred style is to place the close paren after the last condition, and put the open curly on a line by itself.

PJE's patch looks good to me too.

Stylistic nits:

- The proper name of the now-public null importer type ought to be
PyNullImporter_Type, to rhyme with e.g. PyString_Type

- There's a multi-line if that has the closing parenthesis in an odd
place at the start of the next line. The preferred style is to place the
close paren after the last condition, and put the open curly on a line
by itself.

History
Date	User	Action	Args
2007-09-12 18:39:18	gvanrossum	set	spambayes_score: 0.0010511 -> 0.0010511032 recipients: + gvanrossum, loewis, paul.moore, pje, ncoghlan, andy-chu, alexandre.vassalotti
2007-09-12 18:39:18	gvanrossum	set	spambayes_score: 0.0010511 -> 0.0010511 messageid: <1189622358.8.0.998135009606.issue1739468@psf.upfronthosting.co.za>
2007-09-12 18:39:18	gvanrossum	link	issue1739468 messages
2007-09-12 18:39:18	gvanrossum	create