Message52475
Jason, don't worry about the size, I was mostly complaining about the whitespace diffs. I know Tim hadn't done a normalization step for a while. I just did it and am running the tests now. Damn there are a lot! :-(
The good news is that your patch will go down. The bad news for you is that you are going to have to regenerate it and there will probably be conflicts. I'm hoping Martin will review it as he's quite knowledgeable about XML. I doubt there is any more that I can contribute to this patch other than to say it needs some expert eyes on it, but generally looks good.
The tests should be done within 15 minutes or so. Then I'll check in whitespace normalization. |
|
Date |
User |
Action |
Args |
2007-08-23 15:58:06 | admin | link | issue1704134 messages |
2007-08-23 15:58:06 | admin | create | |
|