Message51043
Logged In: YES
user_id=602096
G'day Collin,
I've just had a look at the patch -- looks pretty good.
A couple of things though:
I don't think addTest should check the type of test -- duck
typing is sufficient here. Other testing frameworks should
not have to subclass unittest.TestCase in order to be able
to add their test cases to a unittest.TestSuite.
In loadTestsFromName, it's not strictly necessary to return
TestSuite([test]). The core idea behind the TestLoader
methods is to return something that can be run(). Also, it's
generally not a good idea to change long-standing behaviour
to match documentation. It should be the other way around.
It's really good to see unittest finally getting some love
-- thanks Collin.
jml |
|
Date |
User |
Action |
Args |
2007-08-23 15:54:28 | admin | link | issue1550273 messages |
2007-08-23 15:54:28 | admin | create | |
|