This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author jjlee
Recipients
Date 2007-01-30.02:15:41
SpamBayes Score
Marked as misclassified
Message-id
In-reply-to
Content
Oh the irony. :)

This is good stuff.  I have not reviewed the whole patch, but sampling bits of it it looks fine.  No great danger in committing this, so why not let's commit it?

Of the following points, I think only the first should block commit of this patch.  Any comments on that first point?

1. test_loadTestsFromName__module_not_loaded() and test_loadTestsFromNames__module_not_loaded() -- these may break in future, and may break e.g. only when running tests in random order, which is  sometimes done when debugging obscure stuff.  Better to introduce a module of your own in Lib/test that's guaranteed not to be loaded already -- maybe test_unittest_fodder.py .  Still, that wouldn't help the case where somebody is running the tests in a loop, which would cause failures already (again, this is something people do as part of bug detection / removal).  I don't know the import internals and I hear they're messy, but perhaps just del sys.modules[module_name] at the start of each of those two methods is at least an improvement over what they do now.

2. Would be helpful to list what remains to be tested (for example, there is no test of assertRaises)

3. Why no use of .assertRaises?

4. Would be nice to resolve some of the XXXes, but I realise that this may be difficult/impossible given the requirement for backwards-compatibility
History
Date User Action Args
2007-08-23 15:54:27adminlinkissue1550272 messages
2007-08-23 15:54:27admincreate