Message49632
Logged In: YES
user_id=80475
I believe the patch is not correct for comprehensions with
multiple for-loops. It needs to leave ceval.c, opcode.h,
and opcode.py exactly as the were in Py2.4. Also, the
code for ceval.c should only access the stack through the
stack access macros and avoid derefencing the stack
pointer directly.
The patch should be resubmitted to only modify compile.c
and to produce the same code as in Py2.4 (see example
below and note the inclusion of the DUP_TOP after the
BUILD_LIST). |
|
Date |
User |
Action |
Args |
2007-08-23 15:46:17 | admin | link | issue1442442 messages |
2007-08-23 15:46:17 | admin | create | |
|