Message48807
Logged In: YES
user_id=33168
Thanks for your patch.
I agree there's a problem, though I disagree with the fix.
man fcntl says that the third argument is a long on my box
(gentoo). Is that the same for you (3rd arg is long)? I
don't think the first i (int arg) should be changed. ISTM
only the second part of your patch (modifying the arg
variable) is on the right track. I've attached my version
of the patch, can you test that this works for you? It
seems to work for dnotify, though I'm not sure what it
should do.
Finally, could you create a real unittest in
Lib/test/test_fcntl.py?
Let me know if you agree or disagree with my assessment.
Thanks. |
|
Date |
User |
Action |
Args |
2007-08-23 15:44:05 | admin | link | issue1309352 messages |
2007-08-23 15:44:05 | admin | create | |
|