Message48459
Logged In: YES
user_id=21627
As is, the patch has two major problems:
- TerminateProcess expects a process handle, not a process
ID. This makes the patch pretty useless: To kill a process
other than yourself, you need to call OpenProcess first (or
obtain a process handle in some other way, e.g. by having
created it).
- if the call fails, it uses posix_error to report the
problem. However, posix_error expects that errno is set,
which isn't the case here.
Furthermore, this patch would duplicate
_subprocess.TerminateProcess, which already exposes
TerminateProcess (plus allowing to specify the exit code).
So in its current form, I think the patch should be rejected. |
|
Date |
User |
Action |
Args |
2007-08-23 15:43:16 | admin | link | issue1220212 messages |
2007-08-23 15:43:16 | admin | create | |
|