Message47959
Can you please provide patches to Doc/lib/libheapq.tex and Lib/test/test_heapq.py? Please also put doc strings into the class.
Please drop the type assertions in __init__. I find it quite magical that it will silently turn copy on if the iterator doesn't support len or indexing.
Why is iteration through the heap destructive? No other container has that feature.
Putting the sanity checks into the module isn't necessary - just use the regular test suite for that.
I can't comment further - lack of comments in the patch prevents me from actually understanding it. In the current form, I recommend rejection.
Unassigning Raymond. |
|
Date |
User |
Action |
Args |
2007-08-23 15:42:11 | admin | link | issue1162363 messages |
2007-08-23 15:42:11 | admin | create | |
|