This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author loewis
Recipients
Date 2007-03-06.13:38:13
SpamBayes Score
Marked as misclassified
Message-id
In-reply-to
Content
Can you please provide patches to Doc/lib/libheapq.tex and Lib/test/test_heapq.py? Please also put doc strings into the class.

Please drop the type assertions in __init__. I find it quite magical that it will silently turn copy on if the iterator doesn't support len or indexing.

Why is iteration through the heap destructive? No other container has that feature.

Putting the sanity checks into the module isn't necessary - just use the regular test suite for that.

I can't comment further - lack of comments in the patch prevents me from actually understanding it. In the current form, I recommend rejection.

Unassigning Raymond.
History
Date User Action Args
2007-08-23 15:42:11adminlinkissue1162363 messages
2007-08-23 15:42:11admincreate