Author jafo
Recipients
Date 2004-10-27.03:44:57
SpamBayes Score
Marked as misclassified
Message-id
In-reply-to
Content
Logged In: YES 
user_id=81797

I'm just doing a review of this code.  A couple of things:

   There's been some concern expressed about
get_default_maintainer.
   Namely, that if debchange changes it's algorithm, it won't be
   reflected in this code.  It seems like one possible way
around that
   would be to build a directory with a "debian" directory
under it, a
   fake "changelog", and then call debchange to write the
data out, and
   parse it.  Too bad there's not a direct hook into
debchange to get
   that information.

   Can _formatdate, if email doesn't exist, use
rfc822.formatdate()?

   Ditto for _parseaddr?

It looks pretty good.  However, when trying to build a .deb
of my
jotweb2 package, it's failing with:

   [...]
   dh_testdir
   dh_testroot
   dh_installchangelogs-
   dh_installdocs
   cp: cannot stat `doc': No such file or directory
   dh_installdocs: command returned error code 256
   [...]

I'm not sure exactly why.  I do have a "doc" directory in my
main
package directory, but I don't reference to it in my setup.py or
MANIFEST.  Adding it to the MANIFEST doesn't seem to help this.

Sean
History
Date User Action Args
2007-08-23 15:40:24adminlinkissue1054967 messages
2007-08-23 15:40:24admincreate