Message46805
Logged In: YES
user_id=555
Gustavo, it looks better than my patch.
Two very minor comments:
- The s/wildcare/wildcard/ fix to _sre.c got dropped?
- In this expression, you're checking the first digit, then
the third, then the second. I'd check them in order, for
readability.
c in OCTDIGITS and s.next in OCTDIGITS and this[2] in
OCTDIGITS
As I said, very minor. Thanks for the quick review/apply!
|
|
Date |
User |
Action |
Args |
2007-08-23 15:39:37 | admin | link | issue1018386 messages |
2007-08-23 15:39:37 | admin | create | |
|